Monorepo v6 refactoring: EasySwoole #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexndlm
commented
Jun 23, 2024
alexndlm
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | https://eonx.atlassian.net/browse/MTCE-239 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Code Review in Space: https://eonx.jetbrains.space/p/support/reviews/469/timeline |
…toring-EasySwoole # Conflicts: # packages/EasyHttpClient/composer.json
…toring-EasySwoole # Conflicts: # packages/EasySwoole/bundle/config/doctrine_coroutine_pdo.php # packages/EasySwoole/src/Doctrine/Driver/DbalDriver.php # packages/EasySwoole/src/Doctrine/Factory/CoroutineConnectionFactory.php
…toring-EasySwoole
roman-eonx
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Approved! Code review complete.
Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):
- Protect from Injection attacks
- Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
- Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
- Protect against XSS and CSRF
- Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
- Ensure all important errors and business logic cases are handled
- Ensure forwards and redirects are handled
- Ensure no sensitive data is exposed and appropriate logging in place as required
See procedure for more details: PROC-010 Secure Coding Practices
itorgov
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
good to go
Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):
- Protect from Injection attacks
- Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
- Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
- Protect against XSS and CSRF
- Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
- Ensure all important errors and business logic cases are handled
- Ensure forwards and redirects are handled
- Ensure no sensitive data is exposed and appropriate logging in place as required
See procedure for more details: PROC-010 Secure Coding Practices
roman-eonx
deleted the
feature/MTCE-239-Monorepo-v6-refactoring-EasySwoole
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.